Fix cub::BlockAdjacentDifference documentation #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauleonix
requested review from
elstehle and
miscco
and removed request for
a team
miscco
approved these changes
Oct 11, 2023
|
Thanks a lot for finding and fixing those issues |
|
@miscco "tripping over" them might be a more appropriate description than "finding" them 😆 Happy to help |
|
@pauleonix could you please add [skip ci] to the commit message. We do not want to run CI for plain documentation changes |
Fix factual errors, typos, copy-paste-errors [skip ci]
[skip ci] Co-authored-by: Michael Schellenberger Costa <miscco@nvidia.com>
pauleonix
force-pushed
the
block-adjacent-doc
branch
from
66ae315
to
81e820e
Compare
|
@miscco Like this or rather at the beginning of the title? |
|
/ok to test |
I believe it does not matter, but lets see ;) |
gevtushenko
approved these changes
Oct 11, 2023
[skip ci] Co-authored-by: Georgy Evtushenko <evtushenko.georgy@gmail.com>
|
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix factual errors, typos, copy-paste-errors
Description
closes #541
The documentation for
BlockAdjacentDifferenceseemed very wonky to me both in formulation and in some of the example results provided for the example code snippets and even the order of arguments in one example. I tried correcting all flaws that I found (including some less important copy-paste mistakes and a typo) to the best of my knowledge both from reading the source code and trying it out on CompilerExplorer, but there might be more.This PR was corresponds to NVIDIA/cub#724 where @senior-zero asked me to reapply the changes here.
Checklist