Rework our tuple implementation to work with older MSVC #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
requested review from
griwes,
elstehle and
wmaxey
and removed request for
a team
wmaxey
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We historically had a lot of issues with our tuple implementation and older MSVC compilers, as it really does not play well with their limitations. This has let to a plethora of bug reports and is generally just really annoying.
To add insult to injury, it is one of the blockers for replacing
thrust::tuplewithcuda::std::tupleas the main issue MSVC has (constructing a tuple from less arguments than it has rank) is extensively used within cub and thrustThis PR does two things. It considerably simplifies our implementation, which helps MSVC a lot. It also adds a few selected workarounds to get MSVC to play nice