-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add contributor guide #500
Conversation
53908d9
to
73599e0
Compare
4828f0c
to
f7cf78e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments. I’d be okay with slimmer guides in general. I think some areas are a little too heavy on information. (Should CCCL teach contributors how to fork / clone / make a PR, or should it link to an external guide that covers that information?)
Co-authored-by: Bradley Dice <bdice@bradleydice.com> Co-authored-by: Vyas Ramasubramani <vyas.ramasubramani@gmail.com> Co-authored-by: Allard Hendriksen <allard@allardhendriksen.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good! Nothing to add really aside from what other reviewers already mentioned, except that some of the info regarding our general GHA processes (e.g. copy-pr-bot
and ok to test
) could be reduced even further to just links, but I see the argument for providing at least some basic info about those in this document.
Co-authored-by: Christopher Harris <xixonia@gmail.com>
1646e44
to
81594c7
Compare
d638981
to
6707f87
Compare
Description
Depends on #481
closes #499
Provides a comprehensive guide for CCCL contributors. Updates the ci-overview.md to cover fewer implementation details and more general stuff.