Reenable nvrtc tests #488
Merged
Reenable nvrtc tests #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
requested review from
jarmak-nv and
griwes
and removed request for
a team
miscco
commented
Sep 26, 2023
| @@ -41,7 +41,7 @@ jobs: | |||
| CUDA_VERSIONS: ${{steps.set-outputs.outputs.CUDA_VERSIONS}} | |||
| HOST_COMPILERS: ${{steps.set-outputs.outputs.HOST_COMPILERS}} | |||
| PER_CUDA_COMPILER_MATRIX: ${{steps.set-outputs.outputs.PER_CUDA_COMPILER_MATRIX}} | |||
| NVRTC_MATRIX: ${{steps.set-outputs.outputs.matrix}} | |||
| NVRTC_MATRIX: ${{steps.set-outputs.outputs.NVRTC_MATRIX}} | |||
There was a problem hiding this comment.
Note, this is the main fix
jrhemstad
approved these changes
Sep 26, 2023
currently we did not enable the interoperability of `cuda::std::complex` with `std::complex` for MSVC Fix this to enable it for `thrust::complex`
During a recent refactor there was a typo that disabled the nvrtc tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a recent refactor there was a typo that lead to the nvrtc tests to not run. Fix that bug and also move nvrtc tesst definition to its own file so that we encapsulate all logic there.