Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compute matrix dropping trailing zeros #466

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

jrhemstad
Copy link
Collaborator

Description

The compute-matrix script would process every value through jq -c . to ensure the output was "compact". However, this had the effect of processing some values as numbers which caused problems, e.g., it would drop a trailing zero in the devcontainer_version: 23.10.

Instead, just specify -c on every jq query to ensure compact output.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jrhemstad jrhemstad requested review from a team as code owners September 20, 2023 19:30
@jrhemstad jrhemstad requested review from jarmak-nv, ericniebler and miscco and removed request for a team September 20, 2023 19:30
@miscco miscco merged commit d17334d into NVIDIA:main Sep 21, 2023
459 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants