Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _LIBCUDACXX_CXX03_LANG macro and all encapsulated code #368

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

Blonck
Copy link
Contributor

@Blonck Blonck commented Aug 23, 2023

As part of #127, code for unsupported compilation modes/platforms will be removed. _LICUDACXX_CXX03_LANG macro guards code only compiled for C++03. The macro and all encapsulated code are removed.

Checklist

@Blonck Blonck requested review from a team as code owners August 23, 2023 09:13
@Blonck Blonck requested review from miscco and removed request for a team August 23, 2023 09:13
@rapids-bot
Copy link

rapids-bot bot commented Aug 23, 2023

Pull requests from external contributors require approval from a NVIDIA organization member with write permissions or greater before CI can begin.

@Blonck Blonck requested review from ericniebler and removed request for a team August 23, 2023 09:13
@miscco
Copy link
Collaborator

miscco commented Aug 23, 2023

/ok to test

As part of NVIDIA#127, code for unsupported compilation modes/platforms will
be removed. `_LICUDACXX_CXX03_LANG` macro is used to guard code only
compiled for C++03. The macro and all encapsulated code are removed.
@miscco
Copy link
Collaborator

miscco commented Aug 24, 2023

/ok to test

Copy link
Collaborator

@miscco miscco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, I only found two minor issues in this huge diff

@Blonck Blonck requested a review from a team as a code owner August 24, 2023 12:37
@Blonck Blonck requested review from robertmaynard and removed request for a team August 24, 2023 12:37
Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMake changes LGTM

@miscco
Copy link
Collaborator

miscco commented Aug 24, 2023

/ok to test

@miscco miscco merged commit b6441ee into NVIDIA:main Aug 25, 2023
466 checks passed
ahendriksen pushed a commit to ahendriksen/cccl that referenced this pull request Aug 28, 2023
…#368)

* Remove _LIBCUDACXX_CXX03_LANG macro and all encapsulated code

As part of NVIDIA#127, code for unsupported compilation modes/platforms will
be removed. `_LICUDACXX_CXX03_LANG` macro is used to guard code only
compiled for C++03. The macro and all encapsulated code are removed.

* Remove `__functional_03` and `__functional_base_03`

This patch relates to NVIDIA#127.

---------

Co-authored-by: Martin Marenz <martin.marenz@webfleet.com>
ahendriksen pushed a commit to ahendriksen/cccl that referenced this pull request Aug 28, 2023
…#368)

* Remove _LIBCUDACXX_CXX03_LANG macro and all encapsulated code

As part of NVIDIA#127, code for unsupported compilation modes/platforms will
be removed. `_LICUDACXX_CXX03_LANG` macro is used to guard code only
compiled for C++03. The macro and all encapsulated code are removed.

* Remove `__functional_03` and `__functional_base_03`

This patch relates to NVIDIA#127.

---------

Co-authored-by: Martin Marenz <martin.marenz@webfleet.com>
ahendriksen pushed a commit to ahendriksen/cccl that referenced this pull request Aug 29, 2023
…#368)

* Remove _LIBCUDACXX_CXX03_LANG macro and all encapsulated code

As part of NVIDIA#127, code for unsupported compilation modes/platforms will
be removed. `_LICUDACXX_CXX03_LANG` macro is used to guard code only
compiled for C++03. The macro and all encapsulated code are removed.

* Remove `__functional_03` and `__functional_base_03`

This patch relates to NVIDIA#127.

---------

Co-authored-by: Martin Marenz <martin.marenz@webfleet.com>
ahendriksen pushed a commit to ahendriksen/cccl that referenced this pull request Aug 29, 2023
…#368)

* Remove _LIBCUDACXX_CXX03_LANG macro and all encapsulated code

As part of NVIDIA#127, code for unsupported compilation modes/platforms will
be removed. `_LICUDACXX_CXX03_LANG` macro is used to guard code only
compiled for C++03. The macro and all encapsulated code are removed.

* Remove `__functional_03` and `__functional_base_03`

This patch relates to NVIDIA#127.

---------

Co-authored-by: Martin Marenz <martin.marenz@webfleet.com>
alliepiper pushed a commit to alliepiper/cccl that referenced this pull request Aug 30, 2023
…#368)

* Remove _LIBCUDACXX_CXX03_LANG macro and all encapsulated code

As part of NVIDIA#127, code for unsupported compilation modes/platforms will
be removed. `_LICUDACXX_CXX03_LANG` macro is used to guard code only
compiled for C++03. The macro and all encapsulated code are removed.

* Remove `__functional_03` and `__functional_base_03`

This patch relates to NVIDIA#127.

---------

Co-authored-by: Martin Marenz <martin.marenz@webfleet.com>
ahendriksen pushed a commit to ahendriksen/cccl that referenced this pull request Aug 31, 2023
…#368)

* Remove _LIBCUDACXX_CXX03_LANG macro and all encapsulated code

As part of NVIDIA#127, code for unsupported compilation modes/platforms will
be removed. `_LICUDACXX_CXX03_LANG` macro is used to guard code only
compiled for C++03. The macro and all encapsulated code are removed.

* Remove `__functional_03` and `__functional_base_03`

This patch relates to NVIDIA#127.

---------

Co-authored-by: Martin Marenz <martin.marenz@webfleet.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants