Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make THRUST_DEVICE_SYSTEM and THRUST_CPP_DIALECT independent of THRUST_HOST_SYSTEM #3659

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Make THRUST_DEVICE_SYSTEM and THRUST_CPP_DIALECT independent of THRUST_HOST_SYSTEM #3659

merged 3 commits into from
Feb 5, 2025

Conversation

adams381
Copy link
Contributor

@adams381 adams381 commented Feb 3, 2025

Description

I believe this is the intended behavior.

We hit this issue when testing internally since our testing environment is setting THRUST_HOST_SYSTEM and THRUST_DEVICE_SYSTEM, but not THRUST_CPP_DIALECT. These should be independent of each other.

@adams381
Make THRUST_DEVICE_SYSTEM and THRUST_CPP_DIALECT independent of THRUS…
caa59ca 
…T_HOST_SYSTEM. I believe this is the intended behavior.
@adams381 adams381 requested a review from a team as a code owner February 3, 2025 21:31
@adams381 adams381 requested a review from alliepiper February 3, 2025 21:31
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 3, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@alliepiper
Copy link
Collaborator

/ok to test

@alliepiper
Copy link
Collaborator

/ok to test

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

🟩 CI finished in 1h 38m: Pass: 100%/90 | Total: 18h 24m | Avg: 12m 16s | Max: 1h 22m | Hits: 354%/13398

  • 🟩 cub: Pass: 100%/44 | Total: 10h 02m | Avg: 13m 41s | Max: 1h 22m | Hits: 451%/4168 

    🟩 cpu
  🟩 amd64              Pass: 100%/42  | Total:  9h 50m | Avg: 14m 03s | Max:  1h 22m | Hits: 451%/4168  
  🟩 arm64              Pass: 100%/2   | Total: 12m 10s | Avg:  6m 05s | Max:  6m 28s
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total: 54m 39s | Avg: 10m 55s | Max: 29m 15s | Hits: 536%/1042  
  🟩 12.5               Pass: 100%/2   | Total: 22m 07s | Avg: 11m 03s | Max: 11m 21s
  🟩 12.8               Pass: 100%/37  | Total:  8h 45m | Avg: 14m 12s | Max:  1h 22m | Hits: 423%/3126  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total: 10m 49s | Avg:  5m 24s | Max:  5m 35s
  🟩 nvcc12.0           Pass: 100%/5   | Total: 54m 39s | Avg: 10m 55s | Max: 29m 15s | Hits: 536%/1042  
  🟩 nvcc12.5           Pass: 100%/2   | Total: 22m 07s | Avg: 11m 03s | Max: 11m 21s
  🟩 nvcc12.8           Pass: 100%/35  | Total:  8h 34m | Avg: 14m 42s | Max:  1h 22m | Hits: 423%/3126  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total: 10m 49s | Avg:  5m 24s | Max:  5m 35s
  🟩 nvcc               Pass: 100%/42  | Total:  9h 51m | Avg: 14m 05s | Max:  1h 22m | Hits: 451%/4168  
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total: 25m 36s | Avg:  6m 24s | Max:  6m 46s
  🟩 Clang15            Pass: 100%/2   | Total: 14m 21s | Avg:  7m 10s | Max:  7m 30s
  🟩 Clang16            Pass: 100%/2   | Total: 13m 29s | Avg:  6m 44s | Max:  6m 48s
  🟩 Clang17            Pass: 100%/2   | Total: 13m 56s | Avg:  6m 58s | Max:  7m 22s
  🟩 Clang18            Pass: 100%/7   | Total:  1h 14m | Avg: 10m 42s | Max: 23m 02s
  🟩 GCC7               Pass: 100%/2   | Total: 14m 05s | Avg:  7m 02s | Max:  7m 18s
  🟩 GCC8               Pass: 100%/1   | Total:  6m 34s | Avg:  6m 34s | Max:  6m 34s
  🟩 GCC9               Pass: 100%/2   | Total: 13m 20s | Avg:  6m 40s | Max:  6m 48s
  🟩 GCC10              Pass: 100%/2   | Total: 15m 11s | Avg:  7m 35s | Max:  7m 36s
  🟩 GCC11              Pass: 100%/2   | Total: 14m 17s | Avg:  7m 08s | Max:  7m 29s
  🟩 GCC12              Pass: 100%/2   | Total: 15m 26s | Avg:  7m 43s | Max:  7m 47s
  🟩 GCC13              Pass: 100%/10  | Total:  2h 28m | Avg: 14m 50s | Max: 26m 25s
  🟩 MSVC14.29          Pass: 100%/2   | Total: 56m 50s | Avg: 28m 25s | Max: 29m 15s | Hits: 536%/2084  
  🟩 MSVC14.39          Pass: 100%/2   | Total:  2h 33m | Avg:  1h 16m | Max:  1h 22m | Hits: 366%/2084  
  🟩 NVHPC24.7          Pass: 100%/2   | Total: 22m 07s | Avg: 11m 03s | Max: 11m 21s
🟩 cxx_family
  🟩 Clang              Pass: 100%/17  | Total:  2h 22m | Avg:  8m 22s | Max: 23m 02s
  🟩 GCC                Pass: 100%/21  | Total:  3h 47m | Avg: 10m 49s | Max: 26m 25s
  🟩 MSVC               Pass: 100%/4   | Total:  3h 30m | Avg: 52m 40s | Max:  1h 22m | Hits: 451%/4168  
  🟩 NVHPC              Pass: 100%/2   | Total: 22m 07s | Avg: 11m 03s | Max: 11m 21s
🟩 gpu
  🟩 h100               Pass: 100%/2   | Total: 31m 54s | Avg: 15m 57s | Max: 26m 25s
  🟩 rtx2080            Pass: 100%/34  | Total:  7h 03m | Avg: 12m 27s | Max:  1h 22m | Hits: 451%/4168  
  🟩 rtxa6000           Pass: 100%/8   | Total:  2h 26m | Avg: 18m 21s | Max: 25m 26s
🟩 jobs
  🟩 Build              Pass: 100%/37  | Total:  7h 22m | Avg: 11m 58s | Max:  1h 22m | Hits: 451%/4168  
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 23m 12s | Avg: 23m 12s | Max: 23m 12s
  🟩 GraphCapture       Pass: 100%/1   | Total: 15m 35s | Avg: 15m 35s | Max: 15m 35s
  🟩 HostLaunch         Pass: 100%/3   | Total:  1h 14m | Avg: 24m 57s | Max: 26m 25s
  🟩 TestGPU            Pass: 100%/2   | Total: 45m 57s | Avg: 22m 58s | Max: 24m 04s
🟩 sm
  🟩 90                 Pass: 100%/2   | Total: 31m 54s | Avg: 15m 57s | Max: 26m 25s
  🟩 90;90a;100         Pass: 100%/1   | Total:  7m 12s | Avg:  7m 12s | Max:  7m 12s
🟩 std
  🟩 17                 Pass: 100%/20  | Total:  4h 09m | Avg: 12m 29s | Max:  1h 11m | Hits: 480%/3126  
  🟩 20                 Pass: 100%/24  | Total:  5h 52m | Avg: 14m 41s | Max:  1h 22m | Hits: 365%/1042

  • 🟩 thrust: Pass: 100%/43 | Total: 7h 42m | Avg: 10m 44s | Max: 1h 00m | Hits: 310%/9230 

    🟩 cmake_options
  🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 17m 15s | Avg:  8m 37s | Max: 11m 04s
🟩 cpu
  🟩 amd64              Pass: 100%/41  | Total:  7h 32m | Avg: 11m 01s | Max:  1h 00m | Hits: 310%/9230  
  🟩 arm64              Pass: 100%/2   | Total:  9m 51s | Avg:  4m 55s | Max:  5m 11s
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total: 46m 37s | Avg:  9m 19s | Max: 25m 40s | Hits: 365%/1846  
  🟩 12.5               Pass: 100%/2   | Total: 28m 58s | Avg: 14m 29s | Max: 14m 44s
  🟩 12.8               Pass: 100%/36  | Total:  6h 26m | Avg: 10m 44s | Max:  1h 00m | Hits: 296%/7384  
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total: 10m 54s | Avg:  5m 27s | Max:  5m 33s
  🟩 nvcc12.0           Pass: 100%/5   | Total: 46m 37s | Avg:  9m 19s | Max: 25m 40s | Hits: 365%/1846  
  🟩 nvcc12.5           Pass: 100%/2   | Total: 28m 58s | Avg: 14m 29s | Max: 14m 44s
  🟩 nvcc12.8           Pass: 100%/34  | Total:  6h 15m | Avg: 11m 02s | Max:  1h 00m | Hits: 296%/7384  
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total: 10m 54s | Avg:  5m 27s | Max:  5m 33s
  🟩 nvcc               Pass: 100%/41  | Total:  7h 31m | Avg: 11m 00s | Max:  1h 00m | Hits: 310%/9230  
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total: 21m 15s | Avg:  5m 18s | Max:  5m 37s
  🟩 Clang15            Pass: 100%/2   | Total: 12m 10s | Avg:  6m 05s | Max:  6m 06s
  🟩 Clang16            Pass: 100%/2   | Total: 11m 29s | Avg:  5m 44s | Max:  5m 45s
  🟩 Clang17            Pass: 100%/2   | Total: 11m 32s | Avg:  5m 46s | Max:  5m 48s
  🟩 Clang18            Pass: 100%/7   | Total: 45m 45s | Avg:  6m 32s | Max: 10m 42s
  🟩 GCC7               Pass: 100%/2   | Total: 11m 15s | Avg:  5m 37s | Max:  5m 46s
  🟩 GCC8               Pass: 100%/1   | Total:  5m 57s | Avg:  5m 57s | Max:  5m 57s
  🟩 GCC9               Pass: 100%/2   | Total: 11m 31s | Avg:  5m 45s | Max:  6m 12s
  🟩 GCC10              Pass: 100%/2   | Total: 12m 09s | Avg:  6m 04s | Max:  6m 07s
  🟩 GCC11              Pass: 100%/2   | Total: 12m 32s | Avg:  6m 16s | Max:  6m 40s
  🟩 GCC12              Pass: 100%/2   | Total: 13m 12s | Avg:  6m 36s | Max:  6m 39s
  🟩 GCC13              Pass: 100%/8   | Total:  1h 01m | Avg:  7m 42s | Max: 11m 50s
  🟩 MSVC14.29          Pass: 100%/2   | Total: 49m 24s | Avg: 24m 42s | Max: 25m 40s | Hits: 365%/3692  
  🟩 MSVC14.39          Pass: 100%/3   | Total:  2h 33m | Avg: 51m 06s | Max:  1h 00m | Hits: 273%/5538  
  🟩 NVHPC24.7          Pass: 100%/2   | Total: 28m 58s | Avg: 14m 29s | Max: 14m 44s
🟩 cxx_family
  🟩 Clang              Pass: 100%/17  | Total:  1h 42m | Avg:  6m 00s | Max: 10m 42s
  🟩 GCC                Pass: 100%/19  | Total:  2h 08m | Avg:  6m 44s | Max: 11m 50s
  🟩 MSVC               Pass: 100%/5   | Total:  3h 22m | Avg: 40m 32s | Max:  1h 00m | Hits: 310%/9230  
  🟩 NVHPC              Pass: 100%/2   | Total: 28m 58s | Avg: 14m 29s | Max: 14m 44s
🟩 gpu
  🟩 rtx2080            Pass: 100%/33  | Total:  5h 00m | Avg:  9m 07s | Max:  1h 00m | Hits: 319%/5538  
  🟩 rtx4090            Pass: 100%/10  | Total:  2h 41m | Avg: 16m 06s | Max: 58m 06s | Hits: 296%/3692  
🟩 jobs
  🟩 Build              Pass: 100%/37  | Total:  6h 17m | Avg: 10m 11s | Max:  1h 00m | Hits: 296%/7384  
  🟩 TestCPU            Pass: 100%/3   | Total: 51m 04s | Avg: 17m 01s | Max: 34m 38s | Hits: 365%/1846  
  🟩 TestGPU            Pass: 100%/3   | Total: 33m 36s | Avg: 11m 12s | Max: 11m 50s
🟩 sm
  🟩 90;90a;100         Pass: 100%/1   | Total:  6m 54s | Avg:  6m 54s | Max:  6m 54s
🟩 std
  🟩 17                 Pass: 100%/20  | Total:  3h 37m | Avg: 10m 52s | Max:  1h 00m | Hits: 319%/5538  
  🟩 20                 Pass: 100%/21  | Total:  3h 47m | Avg: 10m 49s | Max: 58m 06s | Hits: 296%/3692

  • 🟩 cccl_c_parallel: Pass: 100%/2 | Total: 7m 32s | Avg: 3m 46s | Max: 5m 20s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total:  7m 32s | Avg:  3m 46s | Max:  5m 20s
🟩 ctk
  🟩 12.8               Pass: 100%/2   | Total:  7m 32s | Avg:  3m 46s | Max:  5m 20s
🟩 cudacxx
  🟩 nvcc12.8           Pass: 100%/2   | Total:  7m 32s | Avg:  3m 46s | Max:  5m 20s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total:  7m 32s | Avg:  3m 46s | Max:  5m 20s
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total:  7m 32s | Avg:  3m 46s | Max:  5m 20s
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total:  7m 32s | Avg:  3m 46s | Max:  5m 20s
🟩 gpu
  🟩 rtx2080            Pass: 100%/2   | Total:  7m 32s | Avg:  3m 46s | Max:  5m 20s
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  2m 12s | Avg:  2m 12s | Max:  2m 12s
  🟩 Test               Pass: 100%/1   | Total:  5m 20s | Avg:  5m 20s | Max:  5m 20s

  • 🟩 python: Pass: 100%/1 | Total: 32m 23s | Avg: 32m 23s | Max: 32m 23s

     
    🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total: 32m 23s | Avg: 32m 23s | Max: 32m 23s
🟩 ctk
  🟩 12.8               Pass: 100%/1   | Total: 32m 23s | Avg: 32m 23s | Max: 32m 23s
🟩 cudacxx
  🟩 nvcc12.8           Pass: 100%/1   | Total: 32m 23s | Avg: 32m 23s | Max: 32m 23s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total: 32m 23s | Avg: 32m 23s | Max: 32m 23s
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total: 32m 23s | Avg: 32m 23s | Max: 32m 23s
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total: 32m 23s | Avg: 32m 23s | Max: 32m 23s
🟩 gpu
  🟩 rtx2080            Pass: 100%/1   | Total: 32m 23s | Avg: 32m 23s | Max: 32m 23s
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total: 32m 23s | Avg: 32m 23s | Max: 32m 23s

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
CUB
+/- Thrust
CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
+/- CUB
+/- Thrust
CUDA Experimental
+/- python
+/- CCCL C Parallel Library
+/- Catch2Helper

🏃‍ Runner counts (total jobs: 90)
# Runner
65 linux-amd64-cpu16
9 windows-amd64-cpu16
6 linux-amd64-gpu-rtxa6000-latest-1
4 linux-arm64-cpu16
3 linux-amd64-gpu-rtx4090-latest-1
2 linux-amd64-gpu-rtx2080-latest-1
1 linux-amd64-gpu-h100-latest-1

@alliepiper alliepiper merged commit dd586a2 into NVIDIA:main Feb 5, 2025
101 of 104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alliepiper alliepiper alliepiper approved these changes

@bernhardmgruber bernhardmgruber bernhardmgruber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
CCCL
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adams381 @alliepiper @bernhardmgruber