Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport branch/2.8.x] Deprecate cub::FpLimits in favor of cuda::std::numeric_limits #3658

Open
wants to merge 1 commit into
base: branch/2.8.x
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 3, 2025

Description

Backport of #3635 to branch/2.8.x.

Copy link

copy-pr-bot bot commented Feb 3, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@leofang
Copy link
Member

leofang commented Feb 3, 2025

Looks like the bot is fixed? 🙂

@bernhardmgruber
Copy link
Contributor

Looks like the bot is fixed? 🙂

This is terrific! :D :D

@bernhardmgruber
Copy link
Contributor

/ok to test

@miscco miscco enabled auto-merge (squash) February 3, 2025 17:12
@leofang
Copy link
Member

leofang commented Feb 3, 2025

Let me know if the workflow breaks again. I hate to see anyone backporting manually! It makes no sense.

That said, if a PR touches files in .github/workflows, or if it contains merge commits, the bot does not work. Something to keep in mind. The merge commit limitation could be relaxed (though I haven't seen a robust proof):
https://github.com/korthout/backport-action#merge_commits

Copy link
Contributor Author

github-actions bot commented Feb 3, 2025

Only merged pull requests can be backported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

2 participants