Remove _NOEXCEPT macro in favor of noexcept in libcu++ #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blonck
requested review from
ericniebler and
alliepiper
and removed request for
a team
|
Pull requests from external contributors require approval from a |
|
Hi, I wanted to get into libcu++ a little bit, if that is ok for you? |
|
/ok to test |
As part of NVIDIA#127 code for unsupported compilation modes/platforms will be removed. `noexcept` is supported by all targeted compilers so the conditional support can be removed.
Blonck
force-pushed
the
remove_noexcept_macro
branch
from
70efc92
to
3074b54
Compare
|
/ok to test |
miscco
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of #127, code for unsupported compilation modes/platforms will be removed.
noexceptis supported by all targeted compilers, so the conditional support can be removed.All uses of the
_NOEXCEPTmacro are replaced bynoexcept.Checklist
[x] I am familiar with the Contributing Guidelines.