Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port cub::DeviceScan tests to catch2 #347

Merged
merged 4 commits into from
Aug 21, 2023

Conversation

elstehle
Copy link
Collaborator

@elstehle elstehle commented Aug 16, 2023

Description

This PR partially addresses #85. It migrates tests for DeviceScan algorithms to Catch2.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@elstehle elstehle requested review from a team as code owners August 16, 2023 19:44
@elstehle elstehle requested review from gevtushenko and griwes and removed request for a team August 16, 2023 19:44
@elstehle elstehle added cub For all items related to CUB infrastructure Shared CMake, github, etc infrastructure labels Aug 16, 2023
Copy link
Collaborator

@gevtushenko gevtushenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments below.

cub/test/catch2_test_device_scan.cu Outdated Show resolved Hide resolved
cub/test/catch2_test_device_scan_iterators.cu Outdated Show resolved Hide resolved
cub/test/catch2_test_device_scan_iterators.cu Outdated Show resolved Hide resolved
cub/test/test_device_scan.cu Show resolved Hide resolved
@elstehle elstehle merged commit 1aa0e03 into NVIDIA:main Aug 21, 2023
435 of 437 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cub For all items related to CUB infrastructure Shared CMake, github, etc infrastructure
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants