Clarify docstring for num_items parameter of DeviceSegmentedRadixSort #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case where the user specifies non-contiguous segments (segments which do not cover the entirety of `d_keys_in`), the `num_items` parameter must include non-covered items. It should be the length of the total range to sort, from the start of the first segment to the end of the last, inclusive of any unused elements.
Clarify docstring for num_items parameter of DeviceSegmentedRadixSort
HapeMask
requested review from
gevtushenko and
wmaxey
and removed request for
a team
|
Pull requests from external contributors require approval from a |
gevtushenko
reviewed
Aug 11, 2023
|
/ok to test |
|
@senior-zero do you have further comments? |
gevtushenko
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the case where the user specifies non-contiguous segments (segments which do not cover the entirety of
d_keys_in), thenum_itemsparameter must include non-covered items. It should be the length of the total range to sort, from the start of the first segment to the end of the last, inclusive of any unused elements.I'm not sure if the wording I used in the docstring is the clearest so please feel free to suggest something better.
For more context / a code example, see: NVIDIA/cub#731