Hide third party cmake options in our cmake developer builds. #300
+47
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alliepiper
requested review from
robertmaynard and
griwes
and removed request for
a team
robertmaynard
requested changes
Aug 3, 2023
This adds a place to list cmake options from our dependencies (e.g. Catch2, etc) that we don't want to display when configuring a developer build with tools like `ccmake` and `cmake-gui`. Fixes NVIDIA#299.
alliepiper
force-pushed
the
tp_cmake_options
branch
from
bd88a9f
to
58385c4
Compare
|
@robertmaynard This is ready for another look. |
robertmaynard
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a place to list cmake options from our dependencies (e.g. Catch2, etc) that we don't want to display when configuring a developer build with tools like
ccmakeandcmake-gui.Fixes #299.
Description
closes #299
Simplifies the process of interactively configuring a CCCL build using tools like
ccmakeandcmake-gui.