gdb pretty printer: handle non-cuda device vectors #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull requests from external contributors require approval from a |
|
@siboehm I cannot push to you branch. Could you please add We want to avoid running full Ci for jobs that have no impact on product code |
miscco
added
feature request
siboehm
force-pushed
the
siboehm/thrust_pretty_printers
branch
from
d4effa9
to
ea9ca78
Compare
|
Done. Strange that you cannot push, this setting has been on from the beginning: |
|
/ok to test |
miscco
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pretty printer assumes that all device vectors live in CUDA mem space. When using e.g. TBB, this fails with:
$1 = Python Exception <class 'gdb.error'>: No symbol "cudaError" in current context.Ported from NVIDIA/thrust#1963