Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BACKPORT]: Ensure that pair is trivially copyable (#1249) #1292

Merged
merged 2 commits into from
Jan 18, 2024
Merged

[BACKPORT]: Ensure that pair is trivially copyable (#1249) #1292

merged 2 commits into from
Jan 18, 2024

Commits on Jan 18, 2024

  1. Ensure that cuda::std::pair is potentially trivially copyable (NVID… 

    …IA#1249)

trivially copyable is a requirement for memcpy. We want to ensure that our pair implementation satisfies that whenever possible.

This is especially important for thrust::pair as that is used in rmm extensively.

Fixes NVIDIA#1246

Co-authored-by: Georgy Evtushenko <evtushenko.georgy@gmail.com>
    @miscco @gevtushenko
    miscco and gevtushenko committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    0642155 View commit details
    Browse the repository at this point in the history

  2. Mark test as passing

    @miscco
    miscco committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    346fa5d View commit details
    Browse the repository at this point in the history