Fix MSVC issues #1261
Merged
Fix MSVC issues #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reasons CI is acting up parsing some macoss specific XFAILs We do not support that, so just remove them
miscco
added
nvbug
miscco
force-pushed
the
fix_various_nvbugs
branch
from
e5e7d14
to
ffa5f7d
Compare
miscco
commented
Jan 10, 2024
| @@ -27,7 +27,7 @@ | |||
|
|
|||
| _LIBCUDACXX_BEGIN_NAMESPACE_STD | |||
|
|
|||
| template<class _Func, class... _Args, class = decltype(std::declval<_Func>()(std::declval<_Args>()...))> | |||
| template<class _Func, class... _Args, class = decltype(_CUDA_VSTD::declval<_Func>()(_CUDA_VSTD::declval<_Args>()...))> | |||
…st qualified type Addresses nvbug3843240
miscco
force-pushed
the
fix_various_nvbugs
branch
from
ffa5f7d
to
a7b9d41
Compare
wmaxey
approved these changes
Jan 17, 2024
|
Backport failed for Please cherry-pick the changes locally. git fetch origin branch/2.3.x
git worktree add -d .worktree/backport-1261-to-branch/2.3.x origin/branch/2.3.x
cd .worktree/backport-1261-to-branch/2.3.x
git checkout -b backport-1261-to-branch/2.3.x
ancref=$(git merge-base 2771c61545eff4ec3cede24ba7963c4eebc4bbaf a7b9d41c3b26f90dac1a7120091b5ce9adab0ac2)
git cherry-pick -x $ancref..a7b9d41c3b26f90dac1a7120091b5ce9adab0ac2 |
miscco
added a commit
to miscco/cccl
that referenced
this pull request
Jan 18, 2024
For some reasons CI is acting up parsing some macoss specific XFAILs We do not support that, so just remove them Fix an issue with MSVC not being able to call `construct_at` on a const qualified type Addresses nvbug3843240
jrhemstad
pushed a commit
that referenced
this pull request
Jan 30, 2024
miscco
added
backport done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses various fixes for MSVC 19.38
Those are mostly test fixes, but also a product code change that ensures that we are able to emplace into an optional with a const qualified base type
Addresses nvbug3843240