Update pytorch base image #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's now a 25.01 release of the pytorch base image, so we should try updating. Signed-off-by: Peter St. John <pstjohn@nvidia.com>
pstjohn
requested review from
dorotat-nv,
jstjohn,
malcolmgreaves,
ohadmo and
trvachov
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #670 +/- ##
=======================================
Coverage 86.27% 86.27%
=======================================
Files 118 118
Lines 7162 7162
=======================================
Hits 6179 6179
Misses 983 983 ☔ View full report in Codecov by Sentry. |
dorotat-nv
approved these changes
Feb 3, 2025
trvachov
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
@dorotat-nv is there any before/after JET test we can look at?
(otherwise looks fine to me)
jstjohn
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's now a 25.01 release of the pytorch base image, so we should try updating.