Revert "pin cdifflib version (#593)" #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2e90bf5. Signed-off-by: Peter St. John <pstjohn@nvidia.com>
pstjohn
requested review from
dorotat-nv,
jstjohn,
malcolmgreaves,
ohadmo and
trvachov
as code owners
cspades
approved these changes
Jan 14, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #599 +/- ##
=======================================
Coverage 88.78% 88.78%
=======================================
Files 81 81
Lines 5027 5027
=======================================
Hits 4463 4463
Misses 564 564 ☔ View full report in Codecov by Sentry. |
dorotat-nv
approved these changes
Jan 14, 2025
|
/build-ci |
1 similar comment
|
/build-ci |
sichu2023
pushed a commit
that referenced
this pull request
Jan 17, 2025
This reverts commit 2e90bf5. ### Description We don't need this anymore (assuming tests pass with the new version) thanks to quick action here: mduggan/cdifflib#13 ### Type of changes <!-- Mark the relevant option with an [x] --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Refactor - [ ] Documentation update - [ ] Other (please describe): ### CI Pipeline Configuration Configure CI behavior by checking relevant boxes below. This will automatically apply labels. - [ ] [SKIP_CI](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#skip_ci) - Skip all continuous integration tests - [ ] [INCLUDE_NOTEBOOKS_TESTS](https://github.com/NVIDIA/bionemo-framework/blob/main/docs/docs/user-guide/contributing/contributing.md#include_notebooks_tests) - Execute notebook validation tests in pytest > [!NOTE] > By default, the notebooks validation tests are skipped unless explicitly enabled. ### Usage <!--- How does a user interact with the changed code --> ```python TODO: Add code snippet ``` ### Pre-submit Checklist <!--- Ensure all items are completed before submitting --> - [ ] I have tested these changes locally - [ ] I have updated the documentation accordingly - [ ] I have added/updated tests as needed - [ ] All existing tests pass successfully Signed-off-by: Peter St. John <pstjohn@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 2e90bf5.
Description
We don't need this anymore (assuming tests pass with the new version) thanks to quick action here: mduggan/cdifflib#13
Type of changes
CI Pipeline Configuration
Configure CI behavior by checking relevant boxes below. This will automatically apply labels.
Note
By default, the notebooks validation tests are skipped unless explicitly enabled.
Usage
Pre-submit Checklist