Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add myself to ci #594

Merged
merged 4 commits into from
Jan 14, 2025
Merged

add myself to ci #594

merged 4 commits into from
Jan 14, 2025

Conversation

nvdreidenbach
Copy link
Collaborator

Adding myself to be able to run ci

Signed-off-by: Danny <dreidenbach@nvidia.com>
Signed-off-by: Danny <dreidenbach@nvidia.com>
@nvdreidenbach
Copy link
Collaborator Author

/build-ci

@nvdreidenbach nvdreidenbach requested a review from jstjohn January 13, 2025 18:16
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.78%. Comparing base (db237fc) to head (72776b0).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #594   +/-   ##
=======================================
  Coverage   88.78%   88.78%           
=======================================
  Files          81       81           
  Lines        5027     5027           
=======================================
  Hits         4463     4463           
  Misses        564      564           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trvachov
Copy link
Collaborator

@pstjohn What CI is running here? blossom or azure? Danny is testing if it's possible to penetrate our blossom CI user list via a simple PR 😬

@pstjohn
Copy link
Collaborator

pstjohn commented Jan 13, 2025

@pstjohn What CI is running here? blossom or azure? Danny is testing if it's possible to penetrate our blossom CI user list via a simple PR 😬

Yeah the azure CI is running, blossom likely won't run with this simple PR.
@nvdreidenbach is a member of the NVIDIA organization, so CI will run without prompting. If he wasn't, we would have had a prompt to enable workflows

See #598 for an example of what that looks like

@nvdreidenbach
Copy link
Collaborator Author

@pstjohn What CI is running here? blossom or azure? Danny is testing if it's possible to penetrate our blossom CI user list via a simple PR 😬

Yeah the azure CI is running, blossom likely won't run with this simple PR. @nvdreidenbach is a member of the NVIDIA organization, so CI will run without prompting. If he wasn't, we would have had a prompt to enable workflow

So I still need to add my name via this MR to run the blossom ci right?

@pstjohn
Copy link
Collaborator

pstjohn commented Jan 13, 2025

I believe you also need to add yourself internally; the blossom folks keep a separate list of authorized users

@nvdreidenbach nvdreidenbach enabled auto-merge (squash) January 14, 2025 01:01
@jstjohn
Copy link
Collaborator

jstjohn commented Jan 14, 2025

/build-ci

@nvdreidenbach nvdreidenbach added the SKIP_CI Completely skips the CI pipeline label Jan 14, 2025
@pstjohn
Copy link
Collaborator

pstjohn commented Jan 14, 2025

/build-ci

@pstjohn pstjohn added the ready PRs that are ready to merge, to coordinate while we don't have a merge queue label Jan 14, 2025
@nvdreidenbach nvdreidenbach merged commit 317177b into NVIDIA:main Jan 14, 2025
7 of 9 checks passed
sichu2023 pushed a commit that referenced this pull request Jan 17, 2025
Adding myself to be able to run ci

---------

Signed-off-by: Danny <dreidenbach@nvidia.com>
Co-authored-by: Timur Rvachov <120140748+trvachov@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs that are ready to merge, to coordinate while we don't have a merge queue SKIP_CI Completely skips the CI pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants