Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump 3rdparty/Megatron-LM from 65720c8 to c76410a #592

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 13, 2025

Bumps 3rdparty/Megatron-LM from 65720c8 to c76410a.

Commits
  • c76410a Merge branch 'ko3n1g/ci/frozen-ckpt' into 'main'
  • b41bcba ADLR/megatron-lm!2514 - ci: Implement frozen-ckpt tests
  • 726da58 Merge branch 'graphable_token_dispatch' into 'main'
  • f27a04f ADLR/megatron-lm!2426 - Make MoE token dispatcher cuda graph-able if token-dr...
  • 3046e33 Merge branch 'jbarker/debug_pp_convert' into 'main'
  • 458bfc9 ADLR/megatron-lm!2523 - Fix bug when loading pp>1 model with frozen layers
  • 8fba594 Merge branch 'hn-inference-cudagraphs-mcore' into 'main'
  • fa93a05 ADLR/megatron-lm!2429 - Inference CUDA graphs (MCore version)
  • 93cb1c1 Merge branch 'huvu/relative_posemd_attention_bias' into 'main'
  • a852cb9 ADLR/megatron-lm!2428 - Adding (bias-based) relative position embedding to T5
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from jstjohn as a code owner January 13, 2025 15:09
@dependabot dependabot bot added dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code labels Jan 13, 2025
@pstjohn
Copy link
Collaborator

pstjohn commented Jan 13, 2025

@dependabot rebase

Bumps [3rdparty/Megatron-LM](https://github.com/NVIDIA/Megatron-LM) from `65720c8` to `c76410a`.
- [Release notes](https://github.com/NVIDIA/Megatron-LM/releases)
- [Commits](NVIDIA/Megatron-LM@65720c8...c76410a)

---
updated-dependencies:
- dependency-name: 3rdparty/Megatron-LM
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/submodules/main/3rdparty/Megatron-LM-c76410a branch from 2080e26 to 49cc4ff Compare January 13, 2025 18:43
@pstjohn pstjohn added the ready PRs that are ready to merge, to coordinate while we don't have a merge queue label Jan 14, 2025
@pstjohn
Copy link
Collaborator

pstjohn commented Jan 14, 2025

/build-ci

@pstjohn pstjohn enabled auto-merge (squash) January 14, 2025 22:11
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.78%. Comparing base (2416d5b) to head (e7882a5).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #592   +/-   ##
=======================================
  Coverage   88.78%   88.78%           
=======================================
  Files          81       81           
  Lines        5027     5027           
=======================================
  Hits         4463     4463           
  Misses        564      564           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pstjohn pstjohn merged commit 93233ff into main Jan 14, 2025
9 checks passed
@pstjohn pstjohn deleted the dependabot/submodules/main/3rdparty/Megatron-LM-c76410a branch January 14, 2025 23:15
sichu2023 pushed a commit that referenced this pull request Jan 17, 2025
Bumps [3rdparty/Megatron-LM](https://github.com/NVIDIA/Megatron-LM) from
`65720c8` to `c76410a`.
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/NVIDIA/Megatron-LM/commit/c76410adec0eb1f81544344fcc2c404166e9913d"><code>c76410a</code></a>
Merge branch 'ko3n1g/ci/frozen-ckpt' into 'main'</li>
<li><a
href="https://github.com/NVIDIA/Megatron-LM/commit/b41bcba26d8dd9b543fa59102363571bb8815dd2"><code>b41bcba</code></a>
ADLR/megatron-lm!2514 - ci: Implement <code>frozen-ckpt</code>
tests</li>
<li><a
href="https://github.com/NVIDIA/Megatron-LM/commit/726da588ead74ac7f5e62324dea478c1dabb4150"><code>726da58</code></a>
Merge branch 'graphable_token_dispatch' into 'main'</li>
<li><a
href="https://github.com/NVIDIA/Megatron-LM/commit/f27a04f6d64e14ebe18cabd807c29cec449ccdc6"><code>f27a04f</code></a>
ADLR/megatron-lm!2426 - Make MoE token dispatcher cuda graph-able if
token-dr...</li>
<li><a
href="https://github.com/NVIDIA/Megatron-LM/commit/3046e33f242d076181436efd4714eae4e40e534e"><code>3046e33</code></a>
Merge branch 'jbarker/debug_pp_convert' into 'main'</li>
<li><a
href="https://github.com/NVIDIA/Megatron-LM/commit/458bfc91f233571c9443597382e673cb15ffe8d0"><code>458bfc9</code></a>
ADLR/megatron-lm!2523 - Fix bug when loading pp&gt;1 model with frozen
layers</li>
<li><a
href="https://github.com/NVIDIA/Megatron-LM/commit/8fba594837b5f6c928c1238262e594640afdfd2e"><code>8fba594</code></a>
Merge branch 'hn-inference-cudagraphs-mcore' into 'main'</li>
<li><a
href="https://github.com/NVIDIA/Megatron-LM/commit/fa93a0564a6d63c13a61e21a403dfb2eea790f74"><code>fa93a05</code></a>
ADLR/megatron-lm!2429 - Inference CUDA graphs (MCore version)</li>
<li><a
href="https://github.com/NVIDIA/Megatron-LM/commit/93cb1c15907da766b47be35c4d326f053775911e"><code>93cb1c1</code></a>
Merge branch 'huvu/relative_posemd_attention_bias' into 'main'</li>
<li><a
href="https://github.com/NVIDIA/Megatron-LM/commit/a852cb9722ec7ded8d12689338513c4e4b314c34"><code>a852cb9</code></a>
ADLR/megatron-lm!2428 - Adding (bias-based) relative position embedding
to T5</li>
<li>Additional commits viewable in <a
href="https://github.com/NVIDIA/Megatron-LM/compare/65720c87ba9c9d0ae8c90b1ffdbdccd2d51b1bc1...c76410adec0eb1f81544344fcc2c404166e9913d">compare
view</a></li>
</ul>
</details>
<br />


Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Peter St. John <pstjohn@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ready PRs that are ready to merge, to coordinate while we don't have a merge queue submodules Pull requests that update Submodules code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants