Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gpu target identificator to JET configs #586

Merged
merged 6 commits into from
Jan 10, 2025

Conversation

dorotat-nv
Copy link
Collaborator

Adding gpu target identification to JET partial configs to distinguish target-specific runs in wandb (executed via JET)

Description

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor
  • Documentation update
  • Other (please describe): JET config update

CI Pipeline Configuration

Configure CI behavior by checking relevant boxes below. This will automatically apply labels.

Note

By default, the notebooks validation tests are skipped unless explicitly enabled.

Pre-submit Checklist

  • I have tested these changes locally
  • I have updated the documentation accordingly
  • I have added/updated tests as needed
  • All existing tests pass successfully

adding target to wandb config

Signed-off-by: Dorota Toczydlowska <115542912+dorotat-nv@users.noreply.github.com>
@github-actions github-actions bot added the SKIP_CI Completely skips the CI pipeline label Jan 9, 2025
@dorotat-nv dorotat-nv self-assigned this Jan 9, 2025
@dorotat-nv dorotat-nv requested a review from cspades January 9, 2025 15:53
Signed-off-by: Dorota Toczydlowska <115542912+dorotat-nv@users.noreply.github.com>
Signed-off-by: Dorota Toczydlowska <115542912+dorotat-nv@users.noreply.github.com>
@dorotat-nv
Copy link
Collaborator Author

/build-ci

Signed-off-by: Dorota Toczydlowska <115542912+dorotat-nv@users.noreply.github.com>
@dorotat-nv
Copy link
Collaborator Author

/build-ci

@dorotat-nv
Copy link
Collaborator Author

/build-ci

@dorotat-nv dorotat-nv enabled auto-merge (squash) January 10, 2025 11:55
@dorotat-nv dorotat-nv merged commit c691df2 into main Jan 10, 2025
8 checks passed
@dorotat-nv dorotat-nv deleted the dorotat/jet-configs-add-target branch January 10, 2025 11:59
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.73%. Comparing base (d36c18e) to head (329b498).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #586   +/-   ##
=======================================
  Coverage   87.73%   87.73%           
=======================================
  Files          89       89           
  Lines        5758     5758           
=======================================
  Hits         5052     5052           
  Misses        706      706           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SKIP_CI Completely skips the CI pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants