Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jwilber/bionemo example small updates #561

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Jwilber/bionemo example small updates #561

merged 4 commits into from
Jan 6, 2025

Conversation

jwilber
Copy link
Collaborator

@jwilber jwilber commented Dec 31, 2024

Went through the example repo over break and found a few very small nitpicks:

  • Minor typos in the README.
  • The finetuning cli script in README had the wrong path
  • Updated tensorboard logging dir in pretrain_script to match the attribute name and finetune script's structure

@jwilber jwilber added the SKIP_CI Completely skips the CI pipeline label Dec 31, 2024
@jwilber jwilber self-assigned this Dec 31, 2024
@jwilber jwilber requested review from trvachov and tshimko-nv January 2, 2025 17:37
jwilber added 2 commits January 2, 2025 09:44
@jwilber
save_dir=directory_name -> save_dir=save_dir
bbe1dd6 
Signed-off-by: Jared Wilber <jwilber@nvidia.com>
@jwilber
small typo fixes and update finetune command
b1d84a7 
Signed-off-by: Jared Wilber <jwilber@nvidia.com>
@jwilber jwilber force-pushed the jwilber/bionemo-example-small-updates branch from 5efc816 to b1d84a7 Compare January 2, 2025 17:45
@jwilber
Copy link
Collaborator Author

jwilber commented Jan 6, 2025

/build-ci

@github-actions github-actions bot removed the SKIP_CI Completely skips the CI pipeline label Jan 6, 2025
@jwilber
Copy link
Collaborator Author

jwilber commented Jan 6, 2025

/build-ci

jstjohn
jstjohn approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@jstjohn jstjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jwilber jwilber merged commit 0640396 into main Jan 6, 2025
6 checks passed
@jwilber jwilber deleted the jwilber/bionemo-example-small-updates branch January 6, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstjohn jstjohn jstjohn approved these changes

@farhadrgh farhadrgh farhadrgh approved these changes

@tshimko-nv tshimko-nv tshimko-nv approved these changes

@malcolmgreaves malcolmgreaves Awaiting requested review from malcolmgreaves malcolmgreaves is a code owner

@skothenhill-nv skothenhill-nv Awaiting requested review from skothenhill-nv skothenhill-nv is a code owner

@trvachov trvachov Awaiting requested review from trvachov

Assignees

@jwilber jwilber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jwilber @jstjohn @farhadrgh @tshimko-nv