RowFeatureIndex Optimization #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polinabinder1
requested review from
jstjohn,
malcolmgreaves,
skothenhill-nv,
ohadmo,
pstjohn and
trvachov
as code owners
|
/build-ci |
sub-packages/bionemo-scdl/tests/bionemo/scdl/index/test_row_feature_index.py
Show resolved
Hide resolved
|
Is the Megatron-LM change intentional? or do we need to do the |
pstjohn
approved these changes
Dec 16, 2024
sub-packages/bionemo-scdl/src/bionemo/scdl/index/row_feature_index.py
Outdated
Show resolved
Hide resolved
sub-packages/bionemo-scdl/tests/bionemo/scdl/index/test_row_feature_index.py
Outdated
Show resolved
Hide resolved
…ndex.py Co-authored-by: Peter St. John <pstjohn@nvidia.com> Signed-off-by: polinabinder1 <pbinder@nvidia.com>
|
/build-ci |
|
/build-ci |
skothenhill-nv
approved these changes
Dec 16, 2024
|
/build-ci |
|
/build-ci |
|
/build-ci |
|
/build-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, if an identical dataframe is appended to RowFeatureIndex as the last one it, instead of storing it, the counter corresponding to the previous dataframe is incremented. This becomes an issue in very large datasets.
Previously, if we had dataframe A corresponding to row [0,2] and we wanted to add the same dataframe A corresponding to 4 more rows, we would store dataframe A twice, with the first copy corresponding to rows [0,2] and the second to [2,6].
Now, we would store dataframe A once and it would correspond to rows [0,6].