Improve upon error reporting in common #389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Bielak <jbielak@nvidia.com>
Signed-off-by: Jan Bielak <jbielak@nvidia.com>
timmoon10
added a commit
to timmoon10/TransformerEngine
that referenced
this pull request
Aug 18, 2023
Incorporating changes from NVIDIA#389. Co-authored-by: Tim Moon <tmoon@nvidia.com> Co-authored-by: Jan Bielak <jbielak@nvidia.com> Signed-off-by: Tim Moon <tmoon@nvidia.com>
|
Can we close this in favor of #382? @timmoon10 @janekb04 |
|
I think so. It seems #382 was rebased on this. |
timmoon10
added a commit
that referenced
this pull request
Oct 24, 2023
* Do not include logging macros in installed C headers Signed-off-by: Tim Moon <tmoon@nvidia.com> * Debug logging macros Signed-off-by: Tim Moon <tmoon@nvidia.com> * Debug C++ tests Use Google style for header includes. Signed-off-by: Tim Moon <tmoon@nvidia.com> * Update CUDA driver macros Incorporating changes from #389. Co-authored-by: Tim Moon <tmoon@nvidia.com> Co-authored-by: Jan Bielak <jbielak@nvidia.com> Signed-off-by: Tim Moon <tmoon@nvidia.com> * Use core error checking macros in PyTorch extensions Hack to get around macro redefinition warning. Signed-off-by: Tim Moon <tmoon@nvidia.com> * Fix missing arg when getting CUDA driver error string Signed-off-by: Tim Moon <tmoon@nvidia.com> * Reuse logging header in frameworks Signed-off-by: Tim Moon <tmoon@nvidia.com> --------- Signed-off-by: Tim Moon <tmoon@nvidia.com> Co-authored-by: Jan Bielak <jbielak@nvidia.com>
mingxu1067
pushed a commit
to mingxu1067/TransformerEngine
that referenced
this pull request
Nov 3, 2023
* Do not include logging macros in installed C headers Signed-off-by: Tim Moon <tmoon@nvidia.com> * Debug logging macros Signed-off-by: Tim Moon <tmoon@nvidia.com> * Debug C++ tests Use Google style for header includes. Signed-off-by: Tim Moon <tmoon@nvidia.com> * Update CUDA driver macros Incorporating changes from NVIDIA#389. Co-authored-by: Tim Moon <tmoon@nvidia.com> Co-authored-by: Jan Bielak <jbielak@nvidia.com> Signed-off-by: Tim Moon <tmoon@nvidia.com> * Use core error checking macros in PyTorch extensions Hack to get around macro redefinition warning. Signed-off-by: Tim Moon <tmoon@nvidia.com> * Fix missing arg when getting CUDA driver error string Signed-off-by: Tim Moon <tmoon@nvidia.com> * Reuse logging header in frameworks Signed-off-by: Tim Moon <tmoon@nvidia.com> --------- Signed-off-by: Tim Moon <tmoon@nvidia.com> Co-authored-by: Jan Bielak <jbielak@nvidia.com> Signed-off-by: Ming Huang <mingh@nvidia.com>
cyanguwa
pushed a commit
to cyanguwa/TransformerEngine
that referenced
this pull request
Nov 13, 2023
* Do not include logging macros in installed C headers Signed-off-by: Tim Moon <tmoon@nvidia.com> * Debug logging macros Signed-off-by: Tim Moon <tmoon@nvidia.com> * Debug C++ tests Use Google style for header includes. Signed-off-by: Tim Moon <tmoon@nvidia.com> * Update CUDA driver macros Incorporating changes from NVIDIA#389. Co-authored-by: Tim Moon <tmoon@nvidia.com> Co-authored-by: Jan Bielak <jbielak@nvidia.com> Signed-off-by: Tim Moon <tmoon@nvidia.com> * Use core error checking macros in PyTorch extensions Hack to get around macro redefinition warning. Signed-off-by: Tim Moon <tmoon@nvidia.com> * Fix missing arg when getting CUDA driver error string Signed-off-by: Tim Moon <tmoon@nvidia.com> * Reuse logging header in frameworks Signed-off-by: Tim Moon <tmoon@nvidia.com> --------- Signed-off-by: Tim Moon <tmoon@nvidia.com> Co-authored-by: Jan Bielak <jbielak@nvidia.com> Signed-off-by: Charlene Yang <8636796+cyanguwa@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked from #377
logging.h.cuGetErrorStringwith wrong number of arguments.