Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PyTorch] Debug checkpointing with operation-based API #1063

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[PyTorch] Debug checkpointing with operation-based API #1063

wants to merge 5 commits into from

Conversation

timmoon10
Copy link
Collaborator

@timmoon10 timmoon10 commented Jul 31, 2024 •
edited
Loading

Description

This PR debugs checkpointing with the operation-based API (see #707). The checkpointing logic is similar to the module-based API.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refractor

Changes

  • Debug checkpointing with operation-based API

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@timmoon10
Debug checkpointing with operation-based API
423b811 
Signed-off-by: Tim Moon <tmoon@nvidia.com>
@timmoon10 timmoon10 added the bug Something isn't working label Jul 31, 2024
@timmoon10 timmoon10 requested a review from ksivaman July 31, 2024 01:56
@timmoon10
Copy link
Collaborator Author

/te-ci pytorch

@timmoon10
Copy link
Collaborator Author

/te-ci pytorch

@timmoon10 timmoon10 mentioned this pull request Sep 10, 2024
Draft
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksivaman ksivaman Awaiting requested review from ksivaman

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@timmoon10