Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minor typo #2473

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Fix minor typo #2473

merged 1 commit into from
Dec 2, 2024

Conversation

lkm2835
Copy link
Contributor

@lkm2835 lkm2835 commented Nov 20, 2024

For tensor parallelism, sharing the embedding table must setuse_parallel_embedding=True and embedding_sharding_dim=0
-> For tensor parallelism, sharing the embedding table must set use_parallel_embedding=True and embedding_sharding_dim=0

@hello-11 hello-11 self-assigned this Nov 25, 2024
@hello-11 hello-11 added the triaged Issue has been triaged by maintainers label Nov 25, 2024
kaiyux
kaiyux approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@kaiyux kaiyux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for fixing it!

@kaiyux kaiyux merged commit 4420547 into NVIDIA:main Dec 2, 2024
@kaiyux kaiyux mentioned this pull request Dec 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaiyux kaiyux kaiyux approved these changes

Assignees

@hello-11 hello-11

Labels
triaged Issue has been triaged by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lkm2835 @kaiyux @hello-11