Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validation errors related to HDR #431

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix validation errors related to HDR #431

wants to merge 3 commits into from

Conversation

res2k
Copy link
Contributor

@res2k res2k commented Jan 9, 2025

  • We're supposed to use VK_COLOR_SPACE_EXTENDED_SRGB_LINEAR_EXT only if VK_EXT_color_space is available.
  • The stretch_pic renderpass references the surface format, so recreate the renderpass if the swapchain changed.

res2k added 3 commits January 9, 2025 15:07
@res2k
Add facility for 'optional' instance extensions
0509610 
Ie, use them if detected, but they're not strictly required.
@res2k
Only look for HDR support if EXT_swapchain_colorspace is available.
2612292 
Fixes a validation error.
@res2k
Create stretch_pic renderpass in vkpt_draw_create_pipelines().
dd1f16f 
Renderpass needs to be recreated when toggling HDR, so put it
into the init function that is called after a swapchain change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@res2k