Keep a small history of 'light counts' for each cluster used for sampling lights (for #226) #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect_model_lights() ...but still keep track of the max. number of lights, upload those to the light buffer, and have sample_polygonal_lights() explicitly use those.
Make room for that extra bit by using few less bits for the x/y values crammed in there as well. (And replace magic shift values with constants while we're at it.)
…ling lights ...instead of just always using the 'max' number seen.
|
@apanteleev Ping? |
|
Merged - thank you. And apologies about the long delay... I was mostly focusing on Portal with RTX in the last few months. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a different approach at addressing #226 after the changes #227 fell short in other scenarios.
I introduced a small history of "cluster light counts" used for light selection.
Now, if light sampling is performed with an "old" RNG seed, we can pull out the light count used at that time from that history we're keeping around (based on the frame number, which is conveniently stored in the RNG seed as well).
This seems to work quite well - it fixes both the problem from #226 but crucially doesn't seem to make things worse if the number of lights in a cluster changes, as previously visible in e.g. the single-player entrance of the
securitymap.(Actually, I'd like to argue that
securitylooks better now, as now the "flashing" at the start, due to jumps in the max light count, is completely absent with this change!)Other changes: