Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go all-in on per-map sky clusters files #219

Merged
merged 7 commits into from
May 12, 2022
Merged

Conversation

res2k
Copy link
Contributor

@res2k res2k commented May 6, 2022

Per-map sky clusters files are the more flexible approach compared to having a monolithic sky_clusters.txt file.
While Q2RTX does support them, it's not very evident - you need to look at the code to realize this.
To provide more visibility the monolithic sky_clusters.txt was split up into map-specific files (using a script, also included).
The documentation referring to sky_clusters.txt has also been updated to mention per-map sky clusters files instead.
Lastly, I removed the code to read sky_clusters.txt.

(That last one is perhaps debatable... it's certainly not needed and making per-map sky clusters files support more visible/advertised could be enough. However, if the file wouldn't be shipped any more, there's little reason left to keep supporting it in the code, IMO.)

@apanteleev apanteleev merged commit 04cf1bb into NVIDIA:master May 12, 2022
@res2k res2k deleted the sky_clusters branch May 12, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants