Go all-in on per-map sky clusters files #219
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per-map sky clusters files are the more flexible approach compared to having a monolithic
sky_clusters.txt
file.While Q2RTX does support them, it's not very evident - you need to look at the code to realize this.
To provide more visibility the monolithic
sky_clusters.txt
was split up into map-specific files (using a script, also included).The documentation referring to
sky_clusters.txt
has also been updated to mention per-map sky clusters files instead.Lastly, I removed the code to read
sky_clusters.txt
.(That last one is perhaps debatable... it's certainly not needed and making per-map sky clusters files support more visible/advertised could be enough. However, if the file wouldn't be shipped any more, there's little reason left to keep supporting it in the code, IMO.)