move cameras to per-map files #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
res2k
reviewed
Dec 16, 2021
| @@ -0,0 +1 @@ | |||
| (-2008.9, 678.2, 206.1) (0.001, -0.810, -0.586) | |||
There was a problem hiding this comment.
the to original cameras.txt had a comment for the "lab" map.
res2k
reviewed
Dec 16, 2021
| VectorCopy(pos, wm->cameras[wm->num_cameras].pos); | ||
| VectorCopy(dir, wm->cameras[wm->num_cameras].dir); | ||
| wm->num_cameras++; | ||
| } |
There was a problem hiding this comment.
Could be helpful for map authors to print a message if MAX_CAMERAS is exceeded.
Break early and warn on too many cameras
|
Pushed with adjustments requested by @res2k |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves cameras away from the single-file system, which is impossible for modders to use for custom maps (with the current system it's impossible to allow downloads of camera files without overwriting all of their cameras, for instance).
One potential improvement is to also allow embedding camera entities in a map, which are ignored by the game code and solely used by the renderer, which eliminates an extra file for new maps, but that's much lower priority.