Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for barrier in not dynamically uniform control flow. #129

Merged
merged 2 commits into from
Aug 23, 2021

Conversation

mpyrzows
Copy link
Contributor

@mpyrzows mpyrzows commented Aug 4, 2021

Barriers in not dynamically uniform control flow are forbidden by the specification. This change moves such barriers present in the tone mapping histogram shader outside of the divergent code.

Barriers in non uniform control flow are forbidden by the specification.
@apanteleev
Copy link
Collaborator

Please rename validSubgroup to validThread or validPixel: it's really about a single thread.

@apanteleev apanteleev merged commit 37e296c into NVIDIA:master Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants