-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve support for old mods #116
Conversation
…fg again ...but also always execute baseq2/autoexec.cfg, if present. This hopefully strikes a balance between "user preference" and "properly support mods" - they may set things in default.cfg that are required to make things work.
...even if their format is 'worse' (ie PCX). This behaviour prevents image from baseq2 to override images from a game, even if it's customized there, but with a format of lower precedence. This ensures the correct 'aesthetic' is applied.
This behaviour prevents md3s from baseq2 to override md2s from a game, allowing mods to, well, modify appearances.
On some custom maps, offsetting one normal meant the 'center' actually ended inside some other geometry, which unfortunately means "not inside any BSP leaf". Scaling down the normal so it's only a little over the plane fixes these cases while still providing a point that's can be associated with a BSP leaf.
Fixes detection of skins ending with UPPERCASE icon file suffixes
Merged with some changes. Specifically, I didn't like the idea of calling the CMake generator from a CMake file, so I changed the configuration to work for both 64-bit targets (full build) and 32-bit targets (server and game only build). Thank you for the contribution! |
The motivation behind the nested CMake call was that 64-bit client, 64-server, but also 32-bit server could be built with a single action; there was no need to manually set up a separate build directory or copy the 32-bit server to the right place... |
I understand the idea, but I believe that CMake should be used for its primary purpose only, i.e. generating solutions or makefiles. When the same system is used to do other things, such as pulling dependencies or building things, that complicates the configuration process, makes it more fragile and less flexible. |
...such as those you'd find in the GOG version of Quake II.
gamex86.dll
game libraries can be used.autoexec.cfg
is present was removed. That behavior broke mods that rely ondefault.cfg
being executed.Limitations:
But hey, it's enough to play against some bots -
start a server with
q2rtxded_x86.exe +set game eraser
, setbot_num
to some value in the terminal, and connect withq2rtx.exe +connect localhost
.