Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable cuda graph based RNN-T greedy inference for r2.0.0rc1 #9904

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

galv
Copy link
Collaborator

@galv galv commented Jul 25, 2024

Temporarily disable cuda graph based RNN-T greedy inference for r2.0.0rc1.

For very rare input shapes, a cooperative kernel might be used by
pytorch for LSTM operations. This does not work within a cuda graph
conditional node until CUDA 12.6.

Unfortunately CUDA 12.6 is not part of the 24.07 pytorch container
release, which this release of nemo is intended for.

r2.0.0rc1.

For very rare input shapes, a cooperative kernel might be used by
pytorch for LSTM operations. This does not work within a cuda graph
conditional node until CUDA 12.6.

Unfortunately CUDA 12.6 is not part of the 24.07 pytorch container
release, which this release of nemo is intended for.

Signed-off-by: Daniel Galvez <dgalvez@nvidia.com>
@github-actions github-actions bot added the ASR label Jul 25, 2024
Copy link
Collaborator

@artbataev artbataev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Collaborator

@nithinraok nithinraok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@nithinraok nithinraok merged commit 2485643 into NVIDIA:r2.0.0rc1 Jul 26, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 26, 2024
r2.0.0rc1.

For very rare input shapes, a cooperative kernel might be used by
pytorch for LSTM operations. This does not work within a cuda graph
conditional node until CUDA 12.6.

Unfortunately CUDA 12.6 is not part of the 24.07 pytorch container
release, which this release of nemo is intended for.

Signed-off-by: Daniel Galvez <dgalvez@nvidia.com>
dimapihtar pushed a commit that referenced this pull request Aug 27, 2024
r2.0.0rc1.

For very rare input shapes, a cooperative kernel might be used by
pytorch for LSTM operations. This does not work within a cuda graph
conditional node until CUDA 12.6.

Unfortunately CUDA 12.6 is not part of the 24.07 pytorch container
release, which this release of nemo is intended for.

Signed-off-by: Daniel Galvez <dgalvez@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants