[NeMo-UX] Fix a minor bug with async checkpointing #9856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… saved on_train_batch_end and on_validation_end within the same step Signed-off-by: ashors1 <ashors@nvidia.com>
mikolajblaz
approved these changes
Jul 24, 2024
ashors1
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
… saved on_train_batch_end and on_validation_end within the same step (#9856) Signed-off-by: ashors1 <ashors@nvidia.com>
BoxiangW
pushed a commit
to BoxiangW/NeMo
that referenced
this pull request
Jul 30, 2024
… saved on_train_batch_end and on_validation_end within the same step (NVIDIA#9856) (NVIDIA#9867) Signed-off-by: ashors1 <ashors@nvidia.com> Co-authored-by: Anna Shors <71393111+ashors1@users.noreply.github.com> Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
xuanzic
pushed a commit
to xuanzic/NeMo
that referenced
this pull request
Aug 1, 2024
… saved on_train_batch_end and on_validation_end within the same step (NVIDIA#9856) (NVIDIA#9867) Signed-off-by: ashors1 <ashors@nvidia.com> Co-authored-by: Anna Shors <71393111+ashors1@users.noreply.github.com> Signed-off-by: Vivian Chen <xuanzic@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
self._last_global_step_savedis being set within the finalize fn, it is only updated when a checkpoint is finalized. This causes an erroneous mismatch betweenself._last_global_step_savedandtrainer.global_step, so this PTL check returnsFalsewhen it should returnTrue. This causes some checkpoints to get saved twice, onceon_train_batch_endand onceon_validation_end. This fixes the problem by updatingself._last_global_step_savedoutside of the finalize function.What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information