Gemma 2 #9708
Merged
Gemma 2 #9708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* gemma2 initial commit Signed-off-by: Chen Cui <chcui@nvidia.com> * enable conversion on cpu Signed-off-by: Chen Cui <chcui@nvidia.com> * fix code scanning Signed-off-by: Chen Cui <chcui@nvidia.com> * typo in config Signed-off-by: Chen Cui <chcui@nvidia.com> * fix output layer and add comments Signed-off-by: Chen Cui <chcui@nvidia.com> * refactor model customize to one function Signed-off-by: Chen Cui <chcui@nvidia.com> * unpin transformers version Signed-off-by: Chen Cui <chcui@nvidia.com> * Apply isort and black reformatting Signed-off-by: cuichenx <cuichenx@users.noreply.github.com> --------- Signed-off-by: Chen Cui <chcui@nvidia.com> Signed-off-by: cuichenx <cuichenx@users.noreply.github.com> Co-authored-by: cuichenx <cuichenx@users.noreply.github.com>
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
…26ab96a77befb Signed-off-by: Chen Cui <chcui@nvidia.com>
cuichenx
previously approved these changes
Aug 7, 2024
…26ab96a77befb Signed-off-by: Chen Cui <chcui@nvidia.com>
cuichenx
previously approved these changes
Aug 15, 2024
cuichenx
previously approved these changes
Aug 15, 2024
Signed-off-by: Chen Cui <chcui@nvidia.com>
cuichenx
approved these changes
Aug 16, 2024
ericharper
deleted the
cherry-pick-main-80e6927cb69af91a1e0ecec4aef26ab96a77befb
branch
Dido0o0
pushed a commit
to Dido0o0/NeMo
that referenced
this pull request
Aug 23, 2024
* Gemma 2 (NVIDIA#9672) * gemma2 initial commit Signed-off-by: Chen Cui <chcui@nvidia.com> * enable conversion on cpu Signed-off-by: Chen Cui <chcui@nvidia.com> * fix code scanning Signed-off-by: Chen Cui <chcui@nvidia.com> * typo in config Signed-off-by: Chen Cui <chcui@nvidia.com> * fix output layer and add comments Signed-off-by: Chen Cui <chcui@nvidia.com> * refactor model customize to one function Signed-off-by: Chen Cui <chcui@nvidia.com> * unpin transformers version Signed-off-by: Chen Cui <chcui@nvidia.com> * Apply isort and black reformatting Signed-off-by: cuichenx <cuichenx@users.noreply.github.com> --------- Signed-off-by: Chen Cui <chcui@nvidia.com> Signed-off-by: cuichenx <cuichenx@users.noreply.github.com> Co-authored-by: cuichenx <cuichenx@users.noreply.github.com> * typo Signed-off-by: Chen Cui <chcui@nvidia.com> * import in function to fix test Signed-off-by: Chen Cui <chcui@nvidia.com> --------- Signed-off-by: Chen Cui <chcui@nvidia.com> Signed-off-by: cuichenx <cuichenx@users.noreply.github.com> Co-authored-by: Chen Cui <chcui@nvidia.com> Co-authored-by: cuichenx <cuichenx@users.noreply.github.com> Co-authored-by: Eric Harper <complex451@gmail.com>
adityavavre
pushed a commit
to adityavavre/NeMo
that referenced
this pull request
Sep 15, 2024
* Gemma 2 (NVIDIA#9672) * gemma2 initial commit Signed-off-by: Chen Cui <chcui@nvidia.com> * enable conversion on cpu Signed-off-by: Chen Cui <chcui@nvidia.com> * fix code scanning Signed-off-by: Chen Cui <chcui@nvidia.com> * typo in config Signed-off-by: Chen Cui <chcui@nvidia.com> * fix output layer and add comments Signed-off-by: Chen Cui <chcui@nvidia.com> * refactor model customize to one function Signed-off-by: Chen Cui <chcui@nvidia.com> * unpin transformers version Signed-off-by: Chen Cui <chcui@nvidia.com> * Apply isort and black reformatting Signed-off-by: cuichenx <cuichenx@users.noreply.github.com> --------- Signed-off-by: Chen Cui <chcui@nvidia.com> Signed-off-by: cuichenx <cuichenx@users.noreply.github.com> Co-authored-by: cuichenx <cuichenx@users.noreply.github.com> * typo Signed-off-by: Chen Cui <chcui@nvidia.com> * import in function to fix test Signed-off-by: Chen Cui <chcui@nvidia.com> --------- Signed-off-by: Chen Cui <chcui@nvidia.com> Signed-off-by: cuichenx <cuichenx@users.noreply.github.com> Co-authored-by: Chen Cui <chcui@nvidia.com> Co-authored-by: cuichenx <cuichenx@users.noreply.github.com> Co-authored-by: Eric Harper <complex451@gmail.com> Signed-off-by: adityavavre <aditya.vavre@gmail.com>
monica-sekoyan
pushed a commit
that referenced
this pull request
Oct 14, 2024
* Gemma 2 (#9672) * gemma2 initial commit Signed-off-by: Chen Cui <chcui@nvidia.com> * enable conversion on cpu Signed-off-by: Chen Cui <chcui@nvidia.com> * fix code scanning Signed-off-by: Chen Cui <chcui@nvidia.com> * typo in config Signed-off-by: Chen Cui <chcui@nvidia.com> * fix output layer and add comments Signed-off-by: Chen Cui <chcui@nvidia.com> * refactor model customize to one function Signed-off-by: Chen Cui <chcui@nvidia.com> * unpin transformers version Signed-off-by: Chen Cui <chcui@nvidia.com> * Apply isort and black reformatting Signed-off-by: cuichenx <cuichenx@users.noreply.github.com> --------- Signed-off-by: Chen Cui <chcui@nvidia.com> Signed-off-by: cuichenx <cuichenx@users.noreply.github.com> Co-authored-by: cuichenx <cuichenx@users.noreply.github.com> * typo Signed-off-by: Chen Cui <chcui@nvidia.com> * import in function to fix test Signed-off-by: Chen Cui <chcui@nvidia.com> --------- Signed-off-by: Chen Cui <chcui@nvidia.com> Signed-off-by: cuichenx <cuichenx@users.noreply.github.com> Co-authored-by: Chen Cui <chcui@nvidia.com> Co-authored-by: cuichenx <cuichenx@users.noreply.github.com> Co-authored-by: Eric Harper <complex451@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Duplicate of #9587 for release branch
Also includes transformers version update from #9606
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information