Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add TN/ITN link in speech tools list #9142

Merged
merged 4 commits into from
May 9, 2024
Merged

add TN/ITN link in speech tools list #9142

merged 4 commits into from
May 9, 2024

Conversation

erastorgueva-nv
Copy link
Collaborator

@erastorgueva-nv erastorgueva-nv commented May 8, 2024

What does this PR do ?

Add link to TN/ITN section of the docs in speech tools list and fix some other issues in (I)TN part of the docs

Collection: Docs

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

N/A

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • [ N/A ] Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • [ N/A ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>
@erastorgueva-nv erastorgueva-nv requested a review from ekmb May 8, 2024 17:18
@github-actions github-actions bot added the NLP label May 8, 2024
Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>
@erastorgueva-nv erastorgueva-nv marked this pull request as ready for review May 8, 2024 18:08
Copy link
Collaborator

@ekmb ekmb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @erastorgueva-nv!

@ericharper ericharper merged commit f58e803 into main May 9, 2024
12 checks passed
@ericharper ericharper deleted the erastorgueva/docs_tn branch May 9, 2024 18:35
BoxiangW pushed a commit to BoxiangW/NeMo that referenced this pull request Jun 5, 2024
* add TN/ITN link in speech tools list

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>

* fix TN docs warnings

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>

---------

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>
Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* add TN/ITN link in speech tools list

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>

* fix TN docs warnings

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>

---------

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants