Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add knob for load_directly_on_device #9125

Merged
merged 5 commits into from
May 10, 2024
Merged

Add knob for load_directly_on_device #9125

merged 5 commits into from
May 10, 2024

Conversation

mikolajblaz
Copy link
Collaborator

What does this PR do ?

Add knob for load_directly_on_device distributed checkpoint loading flag in GPT config.

Collection: NLP

Changelog

  • Add model.dist_ckpt_load_on_device knob for load_directly_on_device distributed checkpoint loading flag

Usage

  • set model.dist_ckpt_load_on_device=False to disable loading checkpoint weights directly on GPU
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
@mikolajblaz mikolajblaz self-assigned this May 7, 2024
@github-actions github-actions bot added the NLP label May 7, 2024
@mikolajblaz mikolajblaz marked this pull request as draft May 7, 2024 09:39
@mikolajblaz mikolajblaz requested a review from akoumpa May 7, 2024 09:39
@mikolajblaz mikolajblaz marked this pull request as ready for review May 8, 2024 06:08
Signed-off-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com>
@akoumpa akoumpa added Run CICD and removed Run CICD labels May 9, 2024
@akoumpa akoumpa merged commit 865839e into main May 10, 2024
38 of 130 checks passed
@akoumpa akoumpa deleted the mblaz/load-on-device-fix branch May 10, 2024 05:48
BoxiangW pushed a commit to BoxiangW/NeMo that referenced this pull request Jun 5, 2024
* Add knob for load_directly_on_device

Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com>
Co-authored-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Pablo Garay <palenq@gmail.com>
Signed-off-by: Boxiang Wang <boxiangw@nvidia.com>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* Add knob for load_directly_on_device

Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com>
Co-authored-by: Alexandros Koumparoulis <153118171+akoumpa@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Pablo Garay <palenq@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants