Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assert for max_steps to be positive in MegatronGPTSFTModel #9110

Merged
merged 1 commit into from
May 6, 2024
Merged

Add assert for max_steps to be positive in MegatronGPTSFTModel #9110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions nemo/collections/nlp/models/language_modeling/megatron_gpt_sft_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ def __init__(self, cfg: DictConfig, trainer: Trainer):
raise ImportError(
"Apex was not found. Please see the NeMo README for installation instructions: https://github.com/NVIDIA/NeMo#megatron-gpt."
)
assert trainer.max_steps > 0, "max_steps for SFT can't be negative as its required to build the dataset"
super().__init__(cfg, trainer=trainer)
self.sep_id = cfg.get('sep_id', 49704)
if hasattr(self.cfg.data, "validation_ds"):
Expand Down
Loading