Implement DistributedCheckpointIO #9016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
mikolajblaz
force-pushed
the
mblaz/dist-ckpt-io
branch
from
d0724bd to
a87313f
Compare
for more information, see https://pre-commit.ci
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
for more information, see https://pre-commit.ci Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
…ist-ckpt-io Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
mikolajblaz
force-pushed
the
mblaz/dist-ckpt-io
branch
from
c7cd76e to
78715de
Compare
The fix from prevent-duplicated-checkpoints is required to skip the checkpoints Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
8 tasks
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
for more information, see https://pre-commit.ci Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
mikolajblaz
force-pushed
the
mblaz/dist-ckpt-io
branch
from
a827444 to
d5e50d6
Compare
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com>
for more information, see https://pre-commit.ci
8 tasks
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
* Introduce DistributedCheckpointIO Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Fix DistCkptIO usage Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Use NeMo logger Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * [DCIO] Fix save_to dist ckpt path Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Use dist ckpt flag in all methods Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Improve error msg Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Add dist ckpt unit tests Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix load_checkpoint Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Fix auto-issues Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Fix ckpt_dir var Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Restore skipping behavior The fix from prevent-duplicated-checkpoints is required to skip the checkpoints Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Fix steps on single-GPU machine Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Add docs Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Apply black Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Fix num steps in tests Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Use dist-ckpt for Bert Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix load checkpoint return val Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Use dist-ckpt based on sharded_state_dict Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * Use correct checkpoint_io Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Mikołaj Błaż <mblaz@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR sets the ground for more advanced distributed checkpointing features, like fully parallel save/load or async save which will be configured and implemented as part of DistributedCheckpointIO plugin. It doesn't introduce any new features, just refactors existing behavior.
Collection: NLP
Changelog
Usage
# Add a code snippet demonstrating how to use thisJenkins CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
There's no need to comment
jenkinson the PR to trigger Jenkins CI.The GitHub Actions CI will run automatically when the PR is opened.
To run CI on an untrusted fork, a NeMo user with write access must click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information