Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSDP + PEFT #8414

Closed
wants to merge 15 commits into from
Closed

FSDP + PEFT #8414

wants to merge 15 commits into from

Conversation

zpx01
Copy link
Collaborator

@zpx01 zpx01 commented Feb 13, 2024

What does this PR do ?

Enables FSDP when using PEFT during training/fine-tuning.

Collection: [NLP]

Changelog

  • Add specific line by line info of high level changes in this PR.

Jenkins CI

To run Jenkins, a NeMo User with write access must comment jenkins on the PR.

Before your PR is "Ready for review"

Pre checks:

  • [ Y] Make sure you read and followed Contributor guidelines
  • [N] Did you write any new necessary tests?
  • [N] Did you add or update any necessary documentation?
  • [N] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • [Y] New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@zpx01 zpx01 changed the title Fsdp peft FSDP + PEFT Feb 13, 2024
@github-actions github-actions bot added the NLP label Feb 13, 2024
Copy link
Contributor

github-actions bot commented Mar 9, 2024

This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days.

@github-actions github-actions bot added the stale label Mar 9, 2024
@cuichenx
Copy link
Collaborator

closing since fsdp + peft is deprioritized

@cuichenx cuichenx closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants