Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily use the previous RNN-T decoding algorithm as default #8226

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

artbataev
Copy link
Collaborator

What does this PR do ?

Use previous RNN-T decoding algorithm as default (loop_labels=False)

Collection: [ASR]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Jenkins CI

To run Jenkins, a NeMo User with write access must comment jenkins on the PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
@artbataev artbataev requested a review from titu1994 January 23, 2024 15:55
@github-actions github-actions bot added the ASR label Jan 23, 2024
@artbataev
Copy link
Collaborator Author

jenkins

@artbataev
Copy link
Collaborator Author

@GNroy, @andrusenkoau FYI

Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@titu1994 titu1994 changed the title Temporarily use the previous RNN-T decoding algorithm as default (before NeMo 2.0) Temporarily use the previous RNN-T decoding algorithm as default Jan 23, 2024
@artbataev artbataev merged commit 0f239ca into main Jan 23, 2024
15 checks passed
@artbataev artbataev deleted the temporary_set_loop_labels_false branch January 23, 2024 19:05
yaoyu-33 pushed a commit that referenced this pull request Jan 31, 2024
Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
stevehuang52 pushed a commit that referenced this pull request Jan 31, 2024
Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
Signed-off-by: stevehuang52 <heh@nvidia.com>
ssh-meister pushed a commit to ssh-meister/NeMo that referenced this pull request Feb 15, 2024
…DIA#8226)

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
Signed-off-by: Sasha Meister <ameister@nvidia.com>
pablo-garay pushed a commit that referenced this pull request Mar 19, 2024
Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
Signed-off-by: Pablo Garay <pagaray@nvidia.com>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants