Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.ctm in data simulator annotator compliant with RT-09 specification #8004
.ctm in data simulator annotator compliant with RT-09 specification #8004
Changes from 16 commits
45baf76
6528af1
6e2aa4e
c9a5b53
6a278db
ca27864
8b62af8
a4dd387
dcfb24a
ccb6005
f0e7ea7
e76e85a
d447492
2e86423
9714854
343c9a7
0de3390
223dc9c
6e6344e
a0397ea
7659d0c
8d94c36
b4bf970
4896351
724adf3
a35a24e
86d5198
604be4d
28cc0d5
eb163fe
4a97f44
23331aa
566c0f3
2eaa24b
1166231
3c82369
4c2421f
9bd0e25
9d73f23
378a14d
e6f16c7
a56d047
3889596
851f716
68cf52f
56a2123
329bc0d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kind of feel that
start_time
is easier to understand thanbeg_time
, without needing to look at the documentationsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it is easier to understand and probably
beg_time
was an ill-suited choice in the initial .ctm specification.On the other hand, if someone is using this function without looking at the specification maybe he should not use it.
IDK I think if we use the original names it is less confusion (even if yeah, it is less intuitive).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed
beg_time
tostart_time
and then mentioned the difference in the docstring.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently,
beg_time
andduration
do not get rounded if they are floats already. Please remove the if-statements, I don't think they are necessary.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to always round the number. Also checking whether beg_time is either float or string containing floating point number.