Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix activation checkpoint #7334

Merged
merged 4 commits into from
Aug 29, 2023
Merged

Fix activation checkpoint #7334

merged 4 commits into from
Aug 29, 2023

Conversation

hsiehjackson
Copy link
Collaborator

What does this PR do ?

Fix issue related to this PR #7200

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>
@github-actions github-actions bot added the NLP label Aug 28, 2023
@hsiehjackson hsiehjackson requested a review from yzhang123 August 29, 2023 17:59
@yzhang123 yzhang123 merged commit e2bdf60 into main Aug 29, 2023
@yzhang123 yzhang123 deleted the fix-activation-checkpoint branch August 29, 2023 18:06
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* Fix activation checkpoint

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

* Remove inference_mode checkpoint

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>

---------

Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants