Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFA tutorial notebook #7210

Merged
merged 4 commits into from
Aug 11, 2023
Merged

NFA tutorial notebook #7210

merged 4 commits into from
Aug 11, 2023

Conversation

erastorgueva-nv
Copy link
Collaborator

What does this PR do ?

Add notebook tutorial for how to use NFA.

Collection: tutorials/tools

Changelog

  • Add new notebook.

Usage

N/A

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • [N/A] Did you write any new necessary tests?
  • [will add links later] Did you add or update any necessary documentation?
  • [ N/A ] Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

erastorgueva-nv and others added 2 commits August 10, 2023 15:41
Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>
@erastorgueva-nv erastorgueva-nv requested a review from vsl9 August 10, 2023 22:46
Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>
Copy link
Collaborator

@vsl9 vsl9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you, Elena!

@erastorgueva-nv erastorgueva-nv merged commit 329629d into main Aug 11, 2023
@erastorgueva-nv erastorgueva-nv deleted the nfa_notebook branch August 11, 2023 02:16
guyueh1 pushed a commit to guyueh1/NeMo that referenced this pull request Aug 14, 2023
* add NFA notebook tutorial

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>

* change single quotes to backticks around model_path

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>

---------

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>
dorotat-nv pushed a commit to dorotat-nv/NeMo that referenced this pull request Aug 24, 2023
* add NFA notebook tutorial

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>

* change single quotes to backticks around model_path

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>

---------

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>
Signed-off-by: dorotat <dorotat@nvidia.com>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* add NFA notebook tutorial

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>

* change single quotes to backticks around model_path

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>

---------

Signed-off-by: Elena Rastorgueva <erastorgueva@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants