Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge main to asr_normalize #7084

Merged
merged 123 commits into from
Jul 20, 2023

memmap worker arg (#7062)

d300a3a
Select commit
Loading
Failed to load commit list.
Merged

Merge main to asr_normalize #7084

memmap worker arg (#7062)
d300a3a
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL failed Jul 20, 2023 in 6s

12 new alerts including 2 errors

New alerts in code changed by this pull request

  • 2 errors
  • 10 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 131 in nemo/collections/asr/parts/numba/rnnt_loss/utils/cuda_utils/gpu_rnnt.py

See this annotation in the file changed.

Code scanning / CodeQL

Mismatch between signature and use of an overridden method Note

Overridden method signature does not match
call
Loading
, where it is passed too many arguments. Overriding method
method GPUTDT.compute_cost_and_score
Loading
matches the call.
Overridden method signature does not match
call
Loading
, where it is passed too many arguments. Overriding method
method GPUTDT.compute_cost_and_score
Loading
matches the call.

Check notice on line 239 in nemo/collections/asr/parts/numba/rnnt_loss/utils/cuda_utils/gpu_rnnt.py

See this annotation in the file changed.

Code scanning / CodeQL

Mismatch between signature and use of an overridden method Note

Overridden method signature does not match
call
Loading
, where it is passed too many arguments. Overriding method
method GPUTDT.cost_and_grad
Loading
matches the call.
Overridden method signature does not match
call
Loading
, where it is passed an argument named 'label_acts'. Overriding method
method GPUTDT.cost_and_grad
Loading
matches the call.
Overridden method signature does not match
call
Loading
, where it is passed an argument named 'duration_acts'. Overriding method
method GPUTDT.cost_and_grad
Loading
matches the call.
Overridden method signature does not match
call
Loading
, where it is passed an argument named 'label_grads'. Overriding method
method GPUTDT.cost_and_grad
Loading
matches the call.
Overridden method signature does not match
call
Loading
, where it is passed an argument named 'duration_grads'. Overriding method
method GPUTDT.cost_and_grad
Loading
matches the call.

Check notice on line 259 in nemo/collections/asr/parts/numba/rnnt_loss/utils/cuda_utils/gpu_rnnt.py

See this annotation in the file changed.

Code scanning / CodeQL

Mismatch between signature and use of an overridden method Note

Overridden method signature does not match
call
Loading
, where it is passed too many arguments. Overriding method
method GPUTDT.score_forward
Loading
matches the call.
Overridden method signature does not match
call
Loading
, where it is passed an argument named 'label_acts'. Overriding method
method GPUTDT.score_forward
Loading
matches the call.
Overridden method signature does not match
call
Loading
, where it is passed an argument named 'duration_acts'. Overriding method
method GPUTDT.score_forward
Loading
matches the call.

Check notice on line 179 in nemo/collections/asr/parts/numba/rnnt_loss/rnnt_pytorch.py

See this annotation in the file changed.

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.

Check notice on line 124 in examples/nlp/language_modeling/tuning/megatron_t5_lora_eval.py

See this annotation in the file changed.

Code scanning / CodeQL

Empty except Note

'except' clause does nothing but pass and there is no explanatory comment.

Check notice on line 129 in examples/nlp/language_modeling/tuning/megatron_t5_lora_eval.py

See this annotation in the file changed.

Code scanning / CodeQL

Empty except Note

'except' clause does nothing but pass and there is no explanatory comment.

Check notice on line 28 in examples/nlp/language_modeling/megatron_gpt_validate.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused import Note

Import of 'MegatronHalfPrecisionPlugin' is not used.
Import of 'PipelineMixedPrecisionPlugin' is not used.

Check notice on line 584 in nemo/collections/asr/models/transformer_bpe_models.py

See this annotation in the file changed.

Code scanning / CodeQL

Explicit returns mixed with implicit (fall through) returns Note

Mixing implicit and explicit returns may indicate an error as implicit returns always return None.

Check notice on line 56 in nemo/collections/asr/models/transformer_bpe_models.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused global variable Note

The global variable 'NLP_AVAILABLE' is not used.

Check notice on line 58 in nemo/collections/asr/models/transformer_bpe_models.py

See this annotation in the file changed.

Code scanning / CodeQL

Unused global variable Note

The global variable 'NLP_AVAILABLE' is not used.

Check failure on line 437 in nemo/collections/asr/data/audio_to_text_dataset.py

See this annotation in the file changed.

Code scanning / CodeQL

Modification of parameter with default Error

This expression mutates a
default value
Loading
.

Check failure on line 439 in nemo/collections/asr/data/audio_to_text_dataset.py

See this annotation in the file changed.

Code scanning / CodeQL

Modification of parameter with default Error

This expression mutates a
default value
Loading
.