Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix k2 build topo helper #6887

Merged
merged 2 commits into from
Jun 20, 2023
Merged

Fix k2 build topo helper #6887

merged 2 commits into from
Jun 20, 2023

Conversation

artbataev
Copy link
Collaborator

@artbataev artbataev commented Jun 20, 2023

What does this PR do ?

Fix build_topo function for k2-based topologies.
This solution fixes failing tests tests/collections/asr/k2/test_ctc.py::TestCTCLossK2::test_case_small_blank_last + tests/collections/asr/k2/test_rnnt.py::TestRNNTLossK2::test_case_small_blank_last

Collection: [ASR]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
@artbataev artbataev requested review from GNroy and fayejf June 20, 2023 12:48
@github-actions github-actions bot added the ASR label Jun 20, 2023
@artbataev artbataev changed the title Fix k2 build topo helper: reassign modified labels attribute Fix k2 build topo helper Jun 20, 2023
Signed-off-by: Vladimir Bataev <vbataev@nvidia.com>
Copy link
Collaborator

@GNroy GNroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@artbataev artbataev merged commit e418f71 into main Jun 20, 2023
@artbataev artbataev deleted the fix_k2_build_topo branch June 20, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants