Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply garbage collection interval to validation steps #6870

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

erhoo82
Copy link
Collaborator

@erhoo82 erhoo82 commented Jun 14, 2023

What does this PR do ?

Apply garbage collection interval to validation steps

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

Auto-applied when using gc_interval > 0

# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Sangkug Lym <slym@nvidia.com>
@erhoo82 erhoo82 requested a review from ericharper June 14, 2023 16:40
@github-actions github-actions bot added the NLP label Jun 14, 2023
@erhoo82 erhoo82 requested a review from aklife97 June 14, 2023 16:40
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ericharper ericharper merged commit f875702 into r1.19.0 Jun 14, 2023
@ericharper ericharper deleted the slym/gc_interval_val branch June 14, 2023 22:50
github-actions bot pushed a commit that referenced this pull request Jun 14, 2023
* Apply garbage collection inverval to validation steps

Signed-off-by: Sangkug Lym <slym@nvidia.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Sangkug Lym <slym@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
ericharper added a commit that referenced this pull request Jun 28, 2023
* Apply garbage collection inverval to validation steps



* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Sangkug Lym <slym@nvidia.com>
Co-authored-by: Sangkug Lym <slym@nvidia.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Eric Harper <complex451@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants