Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FixTextMemMapDataset index file creation in multi-node setup #6768

Merged
merged 5 commits into from
Jun 26, 2023
Merged

FixTextMemMapDataset index file creation in multi-node setup #6768

merged 5 commits into from
Jun 26, 2023

Conversation

gheinrich
Copy link
Contributor

@gheinrich gheinrich commented May 31, 2023 •
edited
Loading

What does this PR do ?

Fixes issue #6715 by creating index files on all processes with local_rank 0.

Collection: NLP

Changelog

  • Update rank condition to create index files when local_rank is 0 (formerly when global_rank was 0).

Usage

  • No change in used.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

@github-actions github-actions bot added core Changes to NeMo Core NLP labels May 31, 2023
@gheinrich gheinrich mentioned this pull request May 31, 2023
Closed
@gheinrich gheinrich force-pushed the dev/gheinrich/text-mmap-dataset-multi-node branch 2 times, most recently from d9ff991 to b97c522 Compare June 6, 2023 13:19
@github-actions github-actions bot removed the core Changes to NeMo Core label Jun 6, 2023
@gheinrich
Fix for isolated filesystems in multi-node setting
cc17abd 
Signed-off-by: Greg Heinrich <gheinrich@nvidia.com>
@gheinrich gheinrich force-pushed the dev/gheinrich/text-mmap-dataset-multi-node branch from 6e172f5 to cc17abd Compare June 6, 2023 20:15
@gheinrich
Copy link
Contributor Author

Hi @michalivne , would you mind taking a look? Thank you!

michalivne
michalivne reviewed Jun 12, 2023
View reviewed changes
Copy link
Collaborator

@michalivne michalivne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Minor question.

nemo/collections/nlp/data/language_modeling/text_memmap_dataset.py Show resolved Hide resolved
@michalivne michalivne merged commit f344fdb into NVIDIA:main Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalivne michalivne michalivne approved these changes

Assignees
No one assigned
Labels
NLP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gheinrich @michalivne