-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TTS] Fix adapter duration issue #6697
Conversation
Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>
Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>
for more information, see https://pre-commit.ci
@hsiehjackson Can you also add the code to increase loss scale for aligner loss may be. We can add these two methods in the tutorial later. I feel the "increasing loss scale for aligner loss" should also be a good approach especially because that doesn't add parameters to finetune. |
Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>
Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>
for more information, see https://pre-commit.ci
@subhankar-ghosh Added |
1 Minor issue, remaining LGTM. |
…into fix_adapter_duration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Fix duration issue Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu> * Fix duration issue Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add scale aligner loss Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix bug Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu> --------- Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: hsiehjackson <c2hsieh@ucsd.edu>
What does this PR do ?
Fix TTS adapter duration issue.
Collection: [TTS]
Changelog
examples/tts/conf/fastpitch_align_44100_adapter.yaml
examples/tts/fastpitch_finetune_adapters.py
nemo/collections/tts/losses/aligner_loss.py
nemo/collections/tts/models/fastpitch.py
tutorials/tts/FastPitch_Adapter_Finetuning.ipynb
Usage
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information