Fix ASR Buffered inference scripts #5552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: smajumdar <titu1994@gmail.com>
Signed-off-by: smajumdar <titu1994@gmail.com>
Signed-off-by: smajumdar <titu1994@gmail.com>
Signed-off-by: smajumdar <titu1994@gmail.com>
Signed-off-by: smajumdar <titu1994@gmail.com>
Signed-off-by: smajumdar <titu1994@gmail.com>
Signed-off-by: smajumdar <titu1994@gmail.com>
fayejf
approved these changes
Dec 6, 2022
|
Definitely need tests for buffered. I didn't add them before cause it was difficult to make it work but with the upgrades now it's easy to take a small pretrained model and add tests to overall + maybe unittests for the internals too. |
andrusenkoau
pushed a commit
to andrusenkoau/NeMo
that referenced
this pull request
Jan 5, 2023
* Fix log calculation Signed-off-by: smajumdar <titu1994@gmail.com> * Fix log calculation Signed-off-by: smajumdar <titu1994@gmail.com> * Fix log check Signed-off-by: smajumdar <titu1994@gmail.com> * Deepcopy the hypothesis to prevent inplace corrections Signed-off-by: smajumdar <titu1994@gmail.com> * Deepcopy the hypothesis to prevent inplace corrections Signed-off-by: smajumdar <titu1994@gmail.com> * Revert changes Signed-off-by: smajumdar <titu1994@gmail.com> * Add link to HF space to readme Signed-off-by: smajumdar <titu1994@gmail.com> Signed-off-by: smajumdar <titu1994@gmail.com> Co-authored-by: fayejf <36722593+fayejf@users.noreply.github.com> Signed-off-by: andrusenkoau <andrusenkoau@gmail.com>
titu1994
added a commit
to titu1994/NeMo
that referenced
this pull request
Mar 24, 2023
* Fix log calculation Signed-off-by: smajumdar <titu1994@gmail.com> * Fix log calculation Signed-off-by: smajumdar <titu1994@gmail.com> * Fix log check Signed-off-by: smajumdar <titu1994@gmail.com> * Deepcopy the hypothesis to prevent inplace corrections Signed-off-by: smajumdar <titu1994@gmail.com> * Deepcopy the hypothesis to prevent inplace corrections Signed-off-by: smajumdar <titu1994@gmail.com> * Revert changes Signed-off-by: smajumdar <titu1994@gmail.com> * Add link to HF space to readme Signed-off-by: smajumdar <titu1994@gmail.com> Signed-off-by: smajumdar <titu1994@gmail.com> Co-authored-by: fayejf <36722593+fayejf@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [ASR]
Changelog
Before your PR is "Ready for review"
Pre checks:
PR Type: