Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TTS] remove phonemizer.py #5071

Merged
merged 2 commits into from
Oct 5, 2022
Merged

[TTS] remove phonemizer.py #5071

merged 2 commits into from
Oct 5, 2022

Conversation

XuesongYang
Copy link
Collaborator

@XuesongYang XuesongYang commented Oct 4, 2022

Signed-off-by: Xuesong Yang 1646669+XuesongYang@users.noreply.github.com

What does this PR do ?

we decided to remove phonemizer python script. We decided to add an instruction about how to transliterate graphemes into phonemes using phonemizer + espeak in the tutorial.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@XuesongYang XuesongYang changed the title [TTS] remove phonemizer.py that relies on espeak under GPL license. [TTS] remove phonemizer.py Oct 4, 2022
Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
Signed-off-by: Xuesong Yang <1646669+XuesongYang@users.noreply.github.com>
@XuesongYang XuesongYang merged commit 2b28d8b into r1.12.0 Oct 5, 2022
@XuesongYang XuesongYang deleted the remove-phonemizer branch October 5, 2022 16:15
@XuesongYang XuesongYang restored the remove-phonemizer branch October 5, 2022 21:44
@XuesongYang XuesongYang mentioned this pull request Oct 5, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants